Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Jun 8, 2025

Description

In some cases VSCode can fail and trigger a client disconnect in the middle of task due to resource limits. We should consider these cases as retry-able.


Important

Enhance runTask() to retry tasks on client disconnection or timeout by tracking task abortion and completion times.

  • Behavior:
    • Track taskAbortedAt in runTask() to handle task abortion events.
    • Modify pWaitFor condition to include taskAbortedAt in runTask().
    • Throw error if client disconnects before task completion in runTask().
  • Logging:
    • Log task abortion and completion times in runTask().
    • Log client disconnection and task closure events in runTask().

This description was created by Ellipsis for df325eb. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners June 8, 2025 18:03
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jun 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 8, 2025
@daniel-lxs daniel-lxs added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 9, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 9, 2025
@daniel-lxs daniel-lxs added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 9, 2025
@cte cte merged commit f5c53f1 into main Jun 9, 2025
21 of 22 checks passed
@cte cte deleted the cte/more-evals-retry-logic branch June 9, 2025 21:26
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 9, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants